js8544 commented on code in PR #14310:
URL: https://github.com/apache/arrow/pull/14310#discussion_r989957207
##########
.github/workflows/cpp.yml:
##########
@@ -182,10 +182,9 @@ jobs:
key: cpp-ccache-macos-${{ hashFiles('cpp/**') }}
restore-keys: cpp-ccache-macos-
- name: Build
- # use brew version of clang, to be consistent with LLVM lib, see
ARROW-17790.
+ # pin LLVM version on MacOS to 14 ARROW-17902
run: |
- export CC=$(brew --prefix llvm)/bin/clang
- export CXX=$(brew --prefix llvm)/bin/clang++
+ export LLVM_ROOT=$(brew --prefix llvm@14)
Review Comment:
The current logic is to check brew paths if the default ones fail. I think a
simpler approach is to append brew paths to LLVM_HINTS. Could you have a look
at the latest changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
