LouisClt commented on code in PR #14219:
URL: https://github.com/apache/arrow/pull/14219#discussion_r990128176
##########
cpp/src/arrow/adapters/orc/adapter.h:
##########
@@ -272,9 +272,12 @@ class ARROW_EXPORT ORCFileWriter {
io::OutputStream* output_stream,
const WriteOptions& write_options = WriteOptions());
- /// \brief Write a table
+ /// \brief Write a table. This can be called multiple times.
///
- /// \param[in] table the Arrow table from which data is extracted
+ /// Tables passed in subsequent calls must match the schema of the table
that was
+ /// written first.
+ ///
+ /// \param[in] table the Arrow table from which data is extracted.
/// \return Status
Status Write(const Table& table);
Review Comment:
Thanks for your review. I think that it would be better indeed, to implement
`Status Write(const RecordBatch& record_batch)` by wrapping the batch in a
table following your reasoning. I will do this, but I will first wait a bit if
others want to comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
