viirya commented on code in PR #2841:
URL: https://github.com/apache/arrow-rs/pull/2841#discussion_r990352268
##########
arrow/src/compute/kernels/arithmetic.rs:
##########
@@ -2145,23 +2145,13 @@ mod tests {
}
#[test]
- #[cfg(not(feature = "simd"))]
fn test_int_array_modulus_overflow_wrapping() {
let a = Int32Array::from(vec![i32::MIN]);
let b = Int32Array::from(vec![-1]);
let result = modulus(&a, &b).unwrap();
assert_eq!(0, result.value(0))
}
- #[test]
Review Comment:
> For example, it caught that the SIMD kernels were using the default %
This?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
