sarahyurick commented on PR #3763: URL: https://github.com/apache/arrow-datafusion/pull/3763#issuecomment-1272135142
One other thing that I considered was that perhaps the table _does_ have a column called "year", etc. These changes don't affect anything like `SELECT year FROM table`, only functions (`SELECT my_func(year, bla, blah, month, etc) FROM table`). We could have the function first check whether or not a field called "year" already exists (such as with the existing `fields_with_unqualified_name` function) and act accordingly. The only case where this wouldn't work is if we had a table with a column called "year" _and_ we were doing a `TIMESTAMPADD` with it, like: `TIMESTAMPADD(year, 1, year)` (where the first "year" is a DateTimeField and the second is the column name). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
