ZMZ91 commented on code in PR #14073:
URL: https://github.com/apache/arrow/pull/14073#discussion_r990574331
##########
cpp/src/gandiva/gdv_function_stubs.cc:
##########
@@ -825,6 +831,11 @@ void ExportedStubFunctions::AddMappings(Engine* engine)
const {
engine->AddGlobalMappingForFunc("gdv_fn_random_with_seed",
types->double_type(), args,
reinterpret_cast<void*>(gdv_fn_random_with_seed));
+ args = {types->i64_type(), types->i64_type(), types->i1_type()};
+ engine->AddGlobalMappingForFunc("gdv_fn_random_with_seed_int64",
types->double_type(),
Review Comment:
To make the random function support both int64 and int32 as the seed, it
requires 2 function signatures with different parameter types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
