HaoYang670 commented on issue #2852: URL: https://github.com/apache/arrow-rs/issues/2852#issuecomment-1272811087
> In the datafusion, we can check the value of precision in the SQL level, and make sure the input precision and scale is valid. If we can check all `precision = 0` cases during the constant folding stage in Datafusion, then it is great. 👍 However, as this is a bug in arrow-rs, we should also add the zero checking here, because arrow-rs is open to all projects, not only the Datafusion. My suggestion is to use `NonZeroU8`, which can avoid duplicated checkings. (avoid checking twice in Datafusion and arrow-rs) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
