rtpsw commented on PR #14347: URL: https://github.com/apache/arrow/pull/14347#issuecomment-1273415978
> I think it's OK to have this, I wonder why the comparison doesn't start with a type comparison though (which should avoid this class of issues) AFAICS, the path of invocations seems to be `Array::Equals` -> `ArrayEquals` -> `ArrayRangeEquals` -> `CompareArrayRanges` -> `TypeEqualsVisitor::Visit(const StructType &)`. This path does not go thorough `TypeEqualsVisitor::VisitChildren`, for example, that would have checked for equal types. Perhaps all visitors methods in `TypeEqualsVisitor` should start with a type comparison. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
