pitrou commented on code in PR #14338:
URL: https://github.com/apache/arrow/pull/14338#discussion_r991415453
##########
cpp/src/arrow/testing/random.cc:
##########
@@ -721,13 +709,11 @@ std::shared_ptr<Array>
RandomArrayGenerator::ArrayOf(const Field& field, int64_t
for (const auto& length : *lengths) {
\
if (length.has_value()) values_length += *length;
\
}
\
- const auto force_empty_nulls =
\
- GetMetadata<bool>(field.metadata().get(), "force_empty_nulls", false);
\
const auto values =
\
ArrayOf(*internal::checked_pointer_cast<ARRAY_TYPE::TypeClass>(field.type()) \
->value_field(),
\
values_length);
\
- const auto offsets = OffsetsFromLengthsArray(lengths.get(),
force_empty_nulls); \
+ const auto offsets = OffsetsFromLengthsArray(lengths.get());
\
Review Comment:
I see. Perhaps we can reconcile all these so as to have a single workhorse
function that takes all desired parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
