benibus commented on PR #14355: URL: https://github.com/apache/arrow/pull/14355#issuecomment-1273673416
A couple notes on this: - I decided to hold off on documenting threading/reentrancy characteristics until I could get a second opinion, as this was my first exposure to the project's async facilities. As it's written, the stated limitations of the CSV equivalent should still apply (no async-reentrancy, no multi-threading). However, here, it _seems_ possible to launch the parsing/decoding tasks in parallel once a chunked block has been serially generated. There may be complexities I'm not considering though. - Test coverage handles the common cases, but likely isn't comprehensive enough - although some of it should be handled by the existing `TableReader` tests since it uses common code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
