nealrichardson commented on code in PR #14175:
URL: https://github.com/apache/arrow/pull/14175#discussion_r991612998
##########
r/R/dplyr-collect.R:
##########
@@ -27,6 +27,10 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
augment_io_error_msg(e, call, schema = x$.data$schema)
}
)
+ # Ungroup the Table before converting this to a data frame
Review Comment:
I wonder if it would be simpler to move the `ungroup()` logic to
`arrow_dplyr_query()` (specifically, around L48 in dplyr.R). That way, we know
that there are no lingering groups in metadata anywhere once we're doing a
dplyr query, the single source of truth is the `arrow_dplyr_query` object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
