emkornfield commented on a change in pull request #8366:
URL: https://github.com/apache/arrow/pull/8366#discussion_r500745907



##########
File path: cpp/src/parquet/arrow/schema.h
##########
@@ -91,7 +91,6 @@ struct PARQUET_EXPORT SchemaField {
   std::shared_ptr<::arrow::Field> field;
   // If field has an extension type, an equivalent field with the storage type,

Review comment:
       Alos, just want to double check that we can always get the raw 
underlying type from the extension types?  One place where this code could 
cause some issues is if a leaf column is filtered out but the extension type 
requires all columns. (this doesn't necessarily apply to this code review as i 
think this was potentially and already existng bug).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to