alamb commented on code in PR #3765:
URL: https://github.com/apache/arrow-datafusion/pull/3765#discussion_r992545113
##########
datafusion/physical-expr/src/regex_expressions.rs:
##########
@@ -300,16 +300,15 @@ pub fn specialize_regexp_replace<T: OffsetSizeTrait>(
// we will create many regexes and it is best to use the implementation
// that caches it. If there are no flags, we can simply ignore it here,
// and let the specialized function handle it.
- (_, true, true, true) => {
- // We still don't know the scalarity of source, so we need the
adapter
- // even if it will do some extra work for the pattern and the
flags.
- //
- // TODO: maybe we need a way of telling the adapter on which
arguments
- // it can skip filling (so that we won't create N - 1 redundant
cols).
- Ok(make_scalar_function(
- _regexp_replace_static_pattern_replace::<T>,
- ))
- }
+ (_, true, true, true) => Ok(make_scalar_function_with_hints(
+ _regexp_replace_static_pattern_replace::<T>,
+ vec![
+ Hint::Pad,
Review Comment:
😍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
