paleolimbot commented on code in PR #14271:
URL: https://github.com/apache/arrow/pull/14271#discussion_r992900054
##########
r/tests/testthat/test-RecordBatch.R:
##########
@@ -642,14 +642,19 @@ test_that("Handling string data with embedded nuls", {
batch_with_nul$b <- batch_with_nul$b$cast(utf8())
withr::with_options(list(arrow.skip_nul = TRUE), {
- expect_warning(
- expect_equal(
- as.data.frame(batch_with_nul)$b,
- c("person", "woman", "man", "camera", "tv"),
- ignore_attr = TRUE
- ),
- "Stripping '\\0' (nul) from character vector",
- fixed = TRUE
+ # Because expect_equal() may call identical(x, y) more than once,
Review Comment:
I think I put 'may' in there to be non-committal since I'm not sure why it
does this...it definitely materializes twice and the backtrace is definitely
from `identical()` both times 🤷 . I'll revisit the test on Monday!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
