pitrou commented on code in PR #14359:
URL: https://github.com/apache/arrow/pull/14359#discussion_r993338597
##########
cpp/src/parquet/encoding.h:
##########
@@ -394,6 +394,20 @@ class DictDecoder : virtual public TypedDecoder<DType> {
// ----------------------------------------------------------------------
// TypedEncoder specializations, traits, and factory functions
+class BooleanDecoder : virtual public TypedDecoder<BooleanType> {
+ public:
+ using TypedDecoder<BooleanType>::Decode;
+
+ /// \brief Decode values into a buffer
+ ///
+ /// \param[in] buffer destination for decoded values
+ /// This buffer contains bit-packed values.
Review Comment:
```suggestion
/// This buffer will contain bit-packed values.
```
##########
cpp/src/parquet/encoding.h:
##########
@@ -394,6 +394,20 @@ class DictDecoder : virtual public TypedDecoder<DType> {
// ----------------------------------------------------------------------
// TypedEncoder specializations, traits, and factory functions
+class BooleanDecoder : virtual public TypedDecoder<BooleanType> {
+ public:
+ using TypedDecoder<BooleanType>::Decode;
+
+ /// \brief Decode values into a buffer
Review Comment:
```suggestion
/// \brief Decode and bit-pack values into a buffer
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
