nealrichardson commented on PR #14281:
URL: https://github.com/apache/arrow/pull/14281#issuecomment-1276047306
I don't think this is concerning. None of the TPC-H queries have the
features that this PR adds support for, so there's not much extra work being
added that would add meaningful time. I did a quick benchmark of the "fast"
path of the function in question here, and it costs <1ms:
```
> q <- rlang:::quos(a + b, c + d, e - f, f(a, b, c))
> bench::mark(arrow:::expand_across(list(), q))
# A tibble: 1 × 13
expression min median itr/s…¹ mem_a…² gc/se…³
n_itr
<bch:expr> <bch:tm> <bch:> <dbl> <bch:b> <dbl>
<int>
1 arrow:::expand_across(list(), q) 87.4µs 91.5µs 10755. 42.9KB 43.7
4923
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
