lidavidm commented on code in PR #14257:
URL: https://github.com/apache/arrow/pull/14257#discussion_r993390753
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -519,7 +519,7 @@ class TeeNode : public compute::MapNode {
MapNode::Finish(std::move(writer_finish_st));
return;
}
- serial_scheduler_->End();
Review Comment:
It almost feels like sub-schedulers should be a different interface (or
parent interface) of the 'main' scheduler so that these methods don't even
exist for clients (though this is not a big deal).
##########
cpp/src/arrow/dataset/file_base.cc:
##########
@@ -519,7 +519,7 @@ class TeeNode : public compute::MapNode {
MapNode::Finish(std::move(writer_finish_st));
return;
}
- serial_scheduler_->End();
Review Comment:
I suppose since we plan to get rid of End() entirely, then this is moot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
