alamb opened a new pull request, #3810: URL: https://github.com/apache/arrow-datafusion/pull/3810
DRAFT as it builds on https://github.com/apache/arrow-datafusion/pull/3809 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/3808 # Rationale for this change The APIs for manipulating expressions were all over the map (sometimes return Vec, sometimes taking them as mut, owned, etc) as well as being inconsistently named and inconsistently tested. In fact I couldn't find `split_filter` (which is similar, but not the same as `split_conjunction`) # What changes are included in this PR? Change the APIs to be consistently named and take reasonable arguments 1. Change `split_conjunction` to return a `Vec` thus simplifying the API 2. Rename split_filter to `split_conjunction_owned` to make it clear how it is related to `split_conjunction` 3. Expand test coverage 2. Rename `combine_filter` to `conjunction` 2. Rename `combine_filter_disjunction` to `disjunction` 4. Change APIs for `conjunction` and `disjunction` to avoid clones I will highlight the changes inline. # Are there any user-facing changes? If anyone uses these APIs they will need to change them, but hopfully -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
