lwhite1 commented on code in PR #14379:
URL: https://github.com/apache/arrow/pull/14379#discussion_r993540348
##########
docs/source/developers/java/building.rst:
##########
@@ -107,33 +111,48 @@ Maven
$ cd arrow/java
$ export JAVA_HOME=<absolute path to your java home>
$ java --version
- $ mvn clean generate-resources -Pgenerate-cdata-dylib_so -N
+ $ mvn generate-resources -Pgenerate-libs-cdata-all-os -N
+ $ # MacOS / Linux
$ ls -latr ../java-dist/lib
|__ libarrow_cdata_jni.dylib
+ |__ libarrow_cdata_jni.so
+ $ # Windows
+ C:\ dir "../java-dist/bin"
+ |__ arrow_cdata_jni.dll
-- To build all JNI libraries except the JNI C Data Interface library:
+- To build all JNI libraries (MacOS / Linux) except the JNI C Data Interface
library:
.. code-block::
$ cd arrow/java
$ export JAVA_HOME=<absolute path to your java home>
$ java --version
- $ mvn clean generate-resources -Pgenerate-jni-dylib_so -N
+ $ mvn generate-resources -Pgenerate-libs-jni-macos-linux -N
$ ls -latr java-dist/lib/*_{jni,java}.*
|__ libarrow_dataset_jni.dylib
|__ libarrow_orc_jni.dylib
|__ libgandiva_jni.dylib
|__ libplasma_java.dylib
+- To build all JNI libraries (Windows) except the JNI C Data Interface library:
+
+ .. code-block::
+
+ C:\ cd arrow/java
+ C:\ java --version
+ C:\ mvn generate-resources -Pgenerate-libs-jni-windows -N
+ C:\ dir "../java-dist/bin"
+ |__ arrow_dataset_jni.dll
+
CMake
~~~~~
-- To build only the JNI C Data Interface library:
+- To build only the JNI C Data Interface library (MacOS / Linux):
.. code-block::
$ cd arrow
- $ mkdir -p java-dist java-cdata
+ $ mkdir -p java-dist java-jni
Review Comment:
This seems like an odd name-change since cdata is much more descriptive
##########
docs/source/developers/java/building.rst:
##########
@@ -107,33 +111,48 @@ Maven
$ cd arrow/java
$ export JAVA_HOME=<absolute path to your java home>
$ java --version
- $ mvn clean generate-resources -Pgenerate-cdata-dylib_so -N
+ $ mvn generate-resources -Pgenerate-libs-cdata-all-os -N
Review Comment:
This looks ok. I'm just curious about why the `clean` was removed.
##########
docs/source/developers/java/building.rst:
##########
@@ -197,6 +236,55 @@ CMake
|__ libgandiva_jni.dylib
|__ libplasma_java.dylib
+- To build all JNI libraries (Windows) except the JNI C Data Interface library
+(Consider: Plasma doesn't work on Windows / ORC isn't available on Windows):
Review Comment:
Maybe "Please note:" instead of "Consider:"
##########
docs/source/developers/java/development.rst:
##########
@@ -81,6 +81,15 @@ UI Benchmark:
.. image:: img/conbench_benchmark.png
+Integration Testing
+===================
+
+Integration testing are running by archery:
Review Comment:
```suggestion
Integration testing are run by archery:
```
##########
docs/source/developers/java/building.rst:
##########
@@ -107,33 +111,48 @@ Maven
$ cd arrow/java
$ export JAVA_HOME=<absolute path to your java home>
$ java --version
- $ mvn clean generate-resources -Pgenerate-cdata-dylib_so -N
+ $ mvn generate-resources -Pgenerate-libs-cdata-all-os -N
+ $ # MacOS / Linux
$ ls -latr ../java-dist/lib
|__ libarrow_cdata_jni.dylib
+ |__ libarrow_cdata_jni.so
+ $ # Windows
Review Comment:
For consistency and clarity, maybe separate MacOS/Linux and Windows into
different blocks under different headings as you did below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
