stiga-huang commented on code in PR #14380:
URL: https://github.com/apache/arrow/pull/14380#discussion_r994080964
##########
cpp/src/arrow/json/converter_test.cc:
##########
@@ -190,9 +190,12 @@ TEST(ConverterTest, Decimal128And256) {
options.explicit_schema = schema({field("", decimal_type)});
std::string json_source = R"(
- {"" : "02.0000000000"}
- {"" : "30.0000000000"}
- )";
+ {"" : "02.0000000000"}
+ {"" : "30.0000000000"}
+ {"" : "30.01"}
+ {"" : "30.0000000000123"}
Review Comment:
I realized that the error handling in other converters are also stop and
return errors, e.g.
https://github.com/apache/arrow/blob/d67a210b8c50b1d109e3d7780591d010e94cc9cc/cpp/src/arrow/json/converter.cc#L132-L134
So I tend to the same behavior now. I think we can add the option for
configurable error handling behavior in a new JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
