AssHero commented on PR #3578: URL: https://github.com/apache/arrow-datafusion/pull/3578#issuecomment-1277267649
> @AssHero do you have some numbers, e.g. how much does it help q19? > > @alamb one thing we might consider is to apply the optimization whenever there is an expensive parent node (joins/aggregate) that benefits from more filtering? Anyway, in most cases, filtering should be cheap compared to other operations as long as the expression is not very expensive (for example, no expensive UDF). Before this commit 'Convert more cross joins to inner joins'(https://github.com/apache/arrow-datafusion/pull/3482)， this optimization helps much in q19, and I intruduce this optimization to solve q19's performance problem. Now q19 is transformed to inner join, and this helps little in q19, but I think this will help other queries with OR clauses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
