davisusanibar commented on code in PR #14379:
URL: https://github.com/apache/arrow/pull/14379#discussion_r994721606
##########
docs/source/developers/java/building.rst:
##########
@@ -87,67 +88,111 @@ Archery
$ java --version
$ archery docker run debian-java
-Building JNI Libraries (.dylib / .so)
--------------------------------------
+Building JNI Libraries (*.dylib / *.so / *.dll)
Review Comment:
Changed
##########
docs/source/developers/java/building.rst:
##########
@@ -87,67 +88,111 @@ Archery
$ java --version
$ archery docker run debian-java
-Building JNI Libraries (.dylib / .so)
--------------------------------------
+Building JNI Libraries (*.dylib / *.so / *.dll)
+-----------------------------------------------
First, we need to build the `C++ shared libraries`_ that the JNI bindings will
use.
We can build these manually or we can use `Archery`_ to build them using a
Docker container
(This will require installing Docker, Docker Compose, and Archery).
-Note: If you are building on Apple Silicon, be sure to use a JDK version that
was compiled
-for that architecture. See, for example, the `Azul JDK
<https://www.azul.com/downloads/?os=macos&architecture=arm-64-bit&package=jdk>`_.
+.. note::
+ If you are building on Apple Silicon, be sure to use a JDK version that was
compiled
+ for that architecture. See, for example, the `Azul JDK
<https://www.azul.com/downloads/?os=macos&architecture=arm-64-bit&package=jdk>`_.
+
+ If you are building on Windows OS, consider to read :ref:`Developing on
Windows <developers-cpp-windows>`.
Maven
~~~~~
-- To build only the JNI C Data Interface library:
+- To build only the JNI C Data Interface library (MacOS / Linux):
.. code-block::
$ cd arrow/java
$ export JAVA_HOME=<absolute path to your java home>
$ java --version
- $ mvn clean generate-resources -Pgenerate-cdata-dylib_so -N
+ $ mvn generate-resources -Pgenerate-libs-cdata-all-os -N
$ ls -latr ../java-dist/lib
|__ libarrow_cdata_jni.dylib
+ |__ libarrow_cdata_jni.so
+
+- To build only the JNI C Data Interface library (Windows):
+
+ .. code-block::
+
+ C:\ cd arrow/java
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
