raulcd commented on code in PR #14033:
URL: https://github.com/apache/arrow/pull/14033#discussion_r994648354
##########
dev/archery/archery/crossbow/cli.py:
##########
@@ -192,6 +192,13 @@ def verify_release_candidate(obj, base_branch, create_pr,
github_token,
# The verify-release-candidate command will create a PR (or find one)
# and add the verify-rc* comment to trigger the verify tasks
+ # Default value for base_branch is the repository's default branch name
+ if base_branch is None:
+ # Get the default branch name from the repository
+ arrow_source_dir = ArrowSources.find()
+ repo = Repo(arrow_source_dir.path)
+ base_branch = repo.default_branch_name
+
# Redefine Arrow repo to use the correct arrow remote.
arrow = Repo(path=obj['arrow'].path, remote_url=remote)
Review Comment:
can't we reuse this Repo instance to retrieve the base branch instead of
creating a new one?
##########
dev/archery/archery/docker/tests/test_docker.py:
##########
@@ -252,12 +252,12 @@ def
test_arrow_example_validation_passes(arrow_compose_path):
def test_compose_default_params_and_env(arrow_compose_path):
compose = DockerCompose(arrow_compose_path, params=dict(
UBUNTU='18.04',
- DASK='master'
+ DASK='main'
Review Comment:
from my understanding this is eventually used on the `install_dask.sh` and
`install_pandas.sh` scripts:
https://github.com/apache/arrow/blob/master/ci/scripts/install_dask.sh#L29
and
https://github.com/apache/arrow/blob/master/ci/scripts/install_pandas.sh#L38
I think we will also have to update these if's otherwise. I've tested to run
the archery command for pandas from current master:
```
$ PANDAS=master archery docker run --no-leaf-cache conda-python-pandas
...
=> => # Collecting git+https://github.com/pandas-dev/pandas.git
=> => # Cloning https://github.com/pandas-dev/pandas.git to
/tmp/pip-req-build-op7u80ho
=> => # Running command git clone --filter=blob:none --quiet
https://github.com/pandas-dev/pandas.git /tmp/pip-req-build-op7u80ho
=> => # Resolved https://github.com/pandas-dev/pandas.git to commit
67d75f3715ed8bfb19edc6d99d16f39daba6e461
=> => # Preparing metadata (pyproject.toml): started
```
and from your branch:
```
$ PANDAS=main archery docker run --no-leaf-cache conda-python-pandas
...
#0 33.87 WARNING: Running pip as the 'root' user can result in broken
permissions and conflicting behaviour with the system package manager. It is
recommended to use a virtual environment instead:
https://pip.pypa.io/warnings/venv
#0 34.39 ERROR: Could not find a version that satisfies the requirement
pandas==main (from versions: 0.1, 0.2, 0.3.0, 0.4.0, 0.4.1, 0.4.2, 0.4.3,
0.5.0, 0.6.0, 0.6.1, 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.8.0, 0.8.1, 0.9.0, 0.9.1,
0.10.0, 0.10.1, 0.11.0, 0.12.0, 0.13.0, 0.13.1, 0.14.0, 0.14.1, 0.15.0, 0.15.1,
0.15.2, 0.16.0, 0.16.1, 0.16.2, 0.17.0, 0.17.1, 0.18.0, 0.18.1, 0.19.0, 0.19.1,
0.19.2, 0.20.0, 0.20.1, 0.20.2, 0.20.3, 0.21.0, 0.21.1, 0.22.0, 0.23.0, 0.23.1,
0.23.2, 0.23.3, 0.23.4, 0.24.0, 0.24.1, 0.24.2, 0.25.0, 0.25.1, 0.25.2, 0.25.3,
1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4,
1.1.5, 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.3.0, 1.3.1, 1.3.2, 1.3.3,
1.3.4, 1.3.5, 1.4.0rc0, 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.5.0rc0, 1.5.0)
#0 34.39 ERROR: No matching distribution found for pandas==main
```
with these changes we would stop testing the latest git version and try to
find main from: `pip install pandas==${pandas}` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
