jhorstmann commented on a change in pull request #8370:
URL: https://github.com/apache/arrow/pull/8370#discussion_r500977682
##########
File path: rust/arrow/src/array/array.rs
##########
@@ -1907,15 +1907,16 @@ impl TryFrom<Vec<(&str, ArrayRef)>> for StructArray {
let mut null: Option<Buffer> = None;
for (field_name, array) in values {
let child_datum = array.data();
+ let child_datum_len = child_datum.len();
Review comment:
If I remember correctly, there might have been an issue a bit further
down where it previously used the len (in bytes) of the null buffer but after
the refactoring needs the length of the array. I don't remember if I did this
for consistency or if it caused a test failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
