Ted-Jiang commented on PR #3780: URL: https://github.com/apache/arrow-datafusion/pull/3780#issuecomment-1278818286
> Thanks @Ted-Jiang -- this is looking quite good. > > I left some comments about how to handle multiple columns > > I would like to see some more tests. Specifically: > > 1. Test that combines column metadata pruning with row filtering > 2. More targeted tests of `prune_pages_in_one_row_group` (specifically setting up various scenarios (including multiple `Index`es) and validating that the output RowSelectors were good > > Given this feature is turned off by default, I also think we could merge this PR as is and iterate on master if you prefer and thus I am approving it. @alamb Thanks for your kindly review! 👍👍 i prefer iterate it on master. I have file the following issue: https://github.com/apache/arrow-datafusion/issues/3834 , https://github.com/apache/arrow-datafusion/issues/3833 and add more tests 💪 As the split the filter-expr (base on `AND`) plan to do it in logical plan, is this ok ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
