ozankabak commented on code in PR #3824:
URL: https://github.com/apache/arrow-datafusion/pull/3824#discussion_r995832991
##########
datafusion/optimizer/src/simplify_expressions.rs:
##########
@@ -794,13 +794,20 @@ impl<'a, S: SimplifyInfo> ExprRewriter for Simplifier<'a,
S> {
op: Divide,
right,
} if is_null(&right) => *right,
- // A / A --> 1 (if a is not nullable)
+ // 0 / 0 -> null
BinaryExpr {
left,
op: Divide,
right,
- } if !info.nullable(&left)? && left == right => lit(1),
-
+ } if is_zero(&left) && is_zero(&right) =>
Expr::Literal(ScalarValue::Int32(None)),
+ // A / 0 --> DivideByZeroError
+ BinaryExpr {
+ left: _,
+ op: Divide,
+ right,
+ } if is_zero(&right) => {
Review Comment:
Should this be `!info.nullable(&left)? && is_zero(&right)` like the modulo
case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
