nealrichardson commented on code in PR #14387: URL: https://github.com/apache/arrow/pull/14387#discussion_r995848072
########## r/R/arrow-package.R: ########## @@ -38,27 +38,33 @@ supported_dplyr_methods <- list( select = NULL, filter = NULL, collect = NULL, - summarise = NULL, + summarise = c( + "window functions not currently supported;", + 'arguments `.drop = FALSE` and `.groups = "rowwise" not supported' + ), group_by = NULL, groups = NULL, group_vars = NULL, group_by_drop_default = NULL, ungroup = NULL, - mutate = NULL, + mutate = c( + "window functions (e.g. things that require aggregation within groups)", Review Comment: Window functions are more than this, though this is in practice how you would trigger them inside `mutate()`. I'll leave it as is (if for no other reason than to save the CI cycles). Who knows, maybe I can make this work for 11.0 and we can remove the note altogether ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
