nealrichardson commented on code in PR #13791: URL: https://github.com/apache/arrow/pull/13791#discussion_r995859454
########## r/NEWS.md: ########## @@ -31,7 +31,8 @@ * `map_batches()` returns a `RecordBatchReader` and requires that the function it maps returns something coercible to a `RecordBatch` through the `as_record_batch()` S3 function. It can also run in streaming fashion if passed `.lazy = TRUE`. (ARROW-15271, ARROW-16703) * Functions can be called with package namespace prefixes (e.g. `stringr::`, `lubridate::`) within queries. For example, `stringr::str_length` will now dispatch to the same kernel as `str_length`. (ARROW-14575) * Support for new functions: - * `lubridate::parse_date_time()` datetime parser: (ARROW-14848, ARROW-16407) + * `lubridate::parse_date_time()` datetime parser: (ARROW-14848, ARROW-16407, ARROW-16653) + * most formats are now supported. Review Comment: @rok could you instead add a note to the binding (see https://github.com/apache/arrow/pull/14387) that explains which tokens are not supported (since it seems like most everything is)? Or make a note that punts on the whole question like the base R docs to and just say "support is platform dependent" and mostly identical to R. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
