naman1996 commented on a change in pull request #8201:
URL: https://github.com/apache/arrow/pull/8201#discussion_r501024248
##########
File path: cpp/src/gandiva/precompiled/string_ops.cc
##########
@@ -84,6 +83,15 @@ VAR_LEN_OP_TYPES(BINARY_RELATIONAL,
greater_than_or_equal_to, >=)
INNER(NAME, utf8) \
INNER(NAME, binary)
+int to_binary_from_hex(char ch) {
Review comment:
will handle only valid hexadecimal characters
a-f, A-F, 0 - 9
There is a check too before invoking this method _isxdigit(hd1) &&
isxdigit(hd2)_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
