onthebridgetonowhere commented on code in PR #329:
URL: https://github.com/apache/arrow-ballista/pull/329#discussion_r996377291


##########
docker-compose.yml:
##########
@@ -54,8 +54,7 @@ services:
     volumes:
       - ./benchmarks/data:/data
     depends_on:
-      ballista-scheduler:
-        condition: service_healthy

Review Comment:
   > `TaskRunnerPool` loops forever, polling schedulers to fetch tasks to run. 
This code opens a new connection to the scheduler each time, which is 
inefficient but does mean that it eventually recovers from scheduler downtime.
   
   I see, I thought it might be the case. Thanks for taking the time to 
explain! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to