[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2883: Skip memory alignment check when constructing PrimitiveArray from an array data reference

[GitBox]

tustvold commented on code in PR #2883:
URL: https://github.com/apache/arrow-rs/pull/2883#discussion_r996384572


##########
arrow-array/src/array/list_array.rs:
##########
@@ -861,16 +861,42 @@ mod tests {
     }
 
     #[test]
-    #[should_panic(expected = "memory is not aligned")]
+    #[should_panic(expected = "Need at least 8 bytes in buffers[0]")]

Review Comment:
   This is why MIRI isn't failing and the debug assertion isn't firing, the 
test panics before it does anything interesting... :facepalm: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org