tustvold commented on code in PR #2886:
URL: https://github.com/apache/arrow-rs/pull/2886#discussion_r996394519
##########
arrow-array/src/array/list_array.rs:
##########
@@ -157,47 +157,26 @@ impl<OffsetSize: OffsetSizeTrait>
GenericListArray<OffsetSize> {
pub fn from_iter_primitive<T, P, I>(iter: I) -> Self
where
T: ArrowPrimitiveType,
- P: AsRef<[Option<<T as ArrowPrimitiveType>::Native>]>
Review Comment:
This AsRef constraint is rather constraining
##########
arrow-array/src/array/list_array.rs:
##########
@@ -157,47 +157,26 @@ impl<OffsetSize: OffsetSizeTrait>
GenericListArray<OffsetSize> {
pub fn from_iter_primitive<T, P, I>(iter: I) -> Self
where
T: ArrowPrimitiveType,
- P: AsRef<[Option<<T as ArrowPrimitiveType>::Native>]>
Review Comment:
This AsRef constraint is rather constraining, it is good to see it gone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
