jorisvandenbossche commented on a change in pull request #8317:
URL: https://github.com/apache/arrow/pull/8317#discussion_r501109018
##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -538,17 +556,17 @@ Status
ParquetFileFragment::EnsureCompleteMetadata(parquet::arrow::FileReader* r
physical_schema_ = std::move(schema);
std::shared_ptr<parquet::FileMetaData> metadata =
reader->parquet_reader()->metadata();
- int num_row_groups = metadata->num_row_groups();
Review comment:
I think we still might need to keep this. Below, it was used for
checking that the ids are not out of bounds. But using `num_row_groups_`, which
can be smaller than the max number of row groups in the file, is the wrong
number to check this, I think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
