pitrou commented on code in PR #14350: URL: https://github.com/apache/arrow/pull/14350#discussion_r997219037
########## docs/source/developers/python.rst: ########## @@ -518,13 +518,11 @@ We set a number of environment variables: - the path of the installation directory of the Arrow C++ libraries as ``ARROW_HOME`` -- add the path of installed DLL libraries to ``PATH`` - and the CMake generator to be used as ``PYARROW_CMAKE_GENERATOR`` .. code-block:: - $ set ARROW_HOME=%cd%\arrow-dist - $ set PATH=%ARROW_HOME%\bin;%PATH% + $ set ARROW_HOME=%CONDA_PREFIX% Review Comment: Hmm, perhaps `ARROW_HOME` is simply not necessary? I just tested without it on Linux and it worked. ########## docs/source/developers/python.rst: ########## @@ -518,13 +518,11 @@ We set a number of environment variables: - the path of the installation directory of the Arrow C++ libraries as ``ARROW_HOME`` -- add the path of installed DLL libraries to ``PATH`` - and the CMake generator to be used as ``PYARROW_CMAKE_GENERATOR`` .. code-block:: - $ set ARROW_HOME=%cd%\arrow-dist - $ set PATH=%ARROW_HOME%\bin;%PATH% + $ set ARROW_HOME=%CONDA_PREFIX% Review Comment: Hmm, perhaps `ARROW_HOME` is simply not necessary anymore? I just tested without it on Linux and it worked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
