kou commented on code in PR #14441:
URL: https://github.com/apache/arrow/pull/14441#discussion_r997513593
##########
ci/conan/all/conanfile.py:
##########
@@ -266,10 +266,7 @@ def _with_boost(self, required=False):
if self.options.gandiva:
return True
version = tools.Version(self.version)
- if version.major == "1":
- if self._parquet() and self.settings.compiler == "gcc" and
self.settings.compiler.version < tools.Version("4.9"):
- return True
- elif version.major >= "2":
+ if version.major >= "2":
Review Comment:
Could you revert all changes in this file?
A Conan package supports multiple versions in the same file. So we still
need to support old versions in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
