pitrou commented on code in PR #14436:
URL: https://github.com/apache/arrow/pull/14436#discussion_r998311684
##########
r/src/recordbatchreader.cpp:
##########
@@ -70,7 +70,7 @@ class RFunctionRecordBatchReader : public
arrow::RecordBatchReader {
arrow::Status ReadNext(std::shared_ptr<arrow::RecordBatch>* batch_out) {
auto batch = SafeCallIntoR<std::shared_ptr<arrow::RecordBatch>>([&]() {
- cpp11::sexp result_sexp = fun_();
+ cpp11::sexp result_sexp = cpp11::function(fun_)();
Review Comment:
Does it potentially defer any type check that would have occurred in the
constructor before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
