alex-natzka commented on code in PR #3861:
URL: https://github.com/apache/arrow-datafusion/pull/3861#discussion_r999150245
##########
benchmarks/expected-plans/q21.txt:
##########
@@ -7,15 +7,18 @@ Sort: numwait DESC NULLS FIRST, supplier.s_name ASC NULLS LAST
Inner Join: l1.l_orderkey = orders.o_orderkey
Inner Join: supplier.s_suppkey = l1.l_suppkey
TableScan: supplier projection=[s_suppkey, s_name, s_nationkey]
- Filter: l1.l_receiptdate > l1.l_commitdate
- SubqueryAlias: l1
- TableScan: lineitem projection=[l_orderkey, l_suppkey,
l_commitdate, l_receiptdate]
- Filter: orders.o_orderstatus = Utf8("F")
- TableScan: orders projection=[o_orderkey, o_orderstatus]
- Filter: nation.n_name = Utf8("SAUDI ARABIA")
- TableScan: nation projection=[n_nationkey, n_name]
+ Filter: l1.l_receiptdate >
l1.l_commitdatel1.l_commitdatel1.l_receiptdate
+ Projection: l1.l_receiptdate > l1.l_commitdate AS
l1.l_receiptdate > l1.l_commitdatel1.l_commitdatel1.l_receiptdate,
l1.l_orderkey, l1.l_suppkey
+ SubqueryAlias: l1
+ TableScan: lineitem projection=[l_orderkey, l_suppkey,
l_commitdate, l_receiptdate]
+ Filter: orders.o_orderstatus =
Utf8("F")Utf8("F")orders.o_orderstatus
+ Projection: orders.o_orderstatus = Utf8("F") AS
orders.o_orderstatus = Utf8("F")Utf8("F")orders.o_orderstatus, orders.o_orderkey
+ TableScan: orders projection=[o_orderkey, o_orderstatus]
+ Filter: nation.n_name = Utf8("SAUDI ARABIA")Utf8("SAUDI
ARABIA")nation.n_name
+ Projection: nation.n_name = Utf8("SAUDI ARABIA") AS
nation.n_name = Utf8("SAUDI ARABIA")Utf8("SAUDI ARABIA")nation.n_name,
nation.n_nationkey
Review Comment:
It's a bit surprising that apparently `CommonSubexprEliminate` now
introduces this projection here even though the expression is used only in one
filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
