rtpsw commented on PR #14385: URL: https://github.com/apache/arrow/pull/14385#issuecomment-1283762465
> > @rtpsw Looks pretty good! There seems to be many style changes that seems orthogonal. Are those changes automatically made? Is it easy to separate out the style change from the actual change? > > If we insist, we could take these style changes out to a separate PR, get that merged, and then come back here to rebase. Anja suggested changing `arrow::engine::substrait` to `arrow::engine::substrait_ext` to avoid MSVC name conflicts with symbols in `::substrait`. This should allow us to keep using `substrait::` instead of `::substrait::` and avoid a large orthogonal change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
