jduo commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r501274245
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2463,7 +2463,7 @@ macro(build_grpc)
endmacro()
if(ARROW_WITH_GRPC)
- set(ARROW_GRPC_REQUIRED_VERSION "1.17.0")
+ set(ARROW_GRPC_REQUIRED_VERSION "1.32.0")
Review comment:
Yeah that's correct. The feature is in 1.27, but in a different
namespace. When I wrote this I figured for convenience of dev we'd want to use
the latest stable release but now see that 1.32 isn't actually available in all
our supported environments (MSYS only has 1.29). So instead what I'm planning:
- Define a macro indicating if TlsCredentialsOptions is supported. I'll see
if it's possible to auto-detect this.
- Define a macro for the namespace holding TlsCredentialsOptions that is
based on version.
- Compile out use of TlsCredentials based on the first macro.
- Revert changes in this PR that update the version the gRPC version 1.32.
- Change the minimum version in the codebase/CI scripts to 1.27 (only if it
is already lower).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
