zeroshade commented on PR #14255: URL: https://github.com/apache/arrow/pull/14255#issuecomment-1284261096
@pitrou The plan is that this would only go to 11.0.0, the maint-10.0.0 branch was already created right? So merges to master won't get included in the RC? > Question: is it useful to have both go/arrow/compute/internal/kernels/_lib/base_arithmetic_avx2_amd64.s and go/arrow/compute/internal/kernels/base_arithmetic_avx2_amd64.s? Is the latter generated from the former? Yes, the latter is generated from the former, able to be regenerated via `make assembly` in the `go/arrow/compute/internal/kernels/` directory. That said, the reason to keep the former around is for easier regeneration of the Go assembly allowing it to be generated without needing a C++ compiler/clang/etc. It ensures consistency where possible (and follows the pattern used elsewhere in the repo for our other use cases of this). Technically it isn't strictly necessary to keep it, I just do for the aforementioned reasons. The latter must be kept around as it needs to be accessible when a user runs `go get` so that Go can assemble it during build. When running `go get` it only builds the files that are there, there is no expectation for a consumer to have to run `make` before building, it "should just work". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
