isidentical commented on PR #3868:
URL:
https://github.com/apache/arrow-datafusion/pull/3868#issuecomment-1284574180
Thank you so much for your reviews @alamb and @Dandandan! I'll try to
address them, but yes, I am also quite excited for the expression boundary
analysis framework 🚀
> The only part of this PR I am not sure about is the calculation of min/max
values for the boolean binary expressions -- however, I think it would also be
fine to merge this PR as is and iterate on master.
@alamb would you mind giving an example? Expression boundaries for a boolean
field (like `a`, or `true`) would be `ExpressionBoundaries { min: true, max:
true, distinct: 1}`. And for a filter that does `a < 5`, we would (or
shouldn't, unless I am missing a scenario) not return a result (since they are
from different datatypes, this analysis is strictly for examples where both
datatypes are the same).
In any case, I'd be happy to also add a test for that case as well (if I
understood the question correctly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
