avantgardnerio commented on code in PR #403: URL: https://github.com/apache/arrow-ballista/pull/403#discussion_r1000789579
########## dev/docker/ballista-scheduler.Dockerfile: ########## @@ -24,7 +24,16 @@ ENV RUST_LOG=info ENV RUST_BACKTRACE=full ENV DEBIAN_FRONTEND=noninteractive -RUN apt-get update && apt-get install -y nginx netcat +RUN apt-get update &&\ + apt-get install -y nginx netcat nodejs npm + +COPY ballista/ui /root/ballista/ui + +RUN cd /root/ballista/ui/scheduler &&\ Review Comment: I'd like to not have any `.sh` files at all. The build should not be complicated: ``` git clone cargo build npm build docker build ``` Every time I see shell scripts, then I see tech debt go into them instead of just making the builds as easy as above. So the only issue here is just that `npm build` didn't go into all the places in the docs where it should, which is my main complaint against docs as well. The CI scripts are the canonical place to look to see how to run a build, and they are under test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
