avantgardnerio commented on code in PR #3907:
URL: https://github.com/apache/arrow-datafusion/pull/3907#discussion_r1001178707
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -118,6 +119,15 @@ message ViewTableScanNode {
string definition = 5;
}
+// Logical Plan to Scan a CustomTableProvider registered at runtime
+message CustomTableScanNode {
+ string table_name = 1;
+ ProjectionColumns projection = 2;
+ datafusion.Schema schema = 3;
+ repeated datafusion.LogicalExprNode filters = 4;
+ bytes custom_table_data = 5;
Review Comment:
The above 4 fields are unrelated to the `TableProvider` - they come from the
`scan`. The `ListingTableScan` doesn't have this problem because it can happily
combine the two logical units into one message, but unless we want each custom
table type to reimplement this logic, we should probably keep it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
