tustvold commented on code in PR #2902:
URL: https://github.com/apache/arrow-rs/pull/2902#discussion_r1001197106
##########
arrow-array/src/array/mod.rs:
##########
@@ -258,6 +283,10 @@ impl Array for ArrayRef {
self.as_ref().as_any()
}
+ fn as_any_arc(self: Arc<Self>) -> Option<Arc<dyn Any + Send + Sync +
'static>> {
Review Comment:
I was really confused how this was working, and then realised this is
actually implementing `as_any_arc` for `Arc<Arc<dyn Array>>` :sweat_smile:
Perhaps this should return `None` to be consistent with `as_any` above which
calls through to the inner array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
