tustvold commented on code in PR #2905:
URL: https://github.com/apache/arrow-rs/pull/2905#discussion_r1001212862
##########
arrow/src/array/ord.rs:
##########
@@ -307,10 +315,34 @@ pub fn build_compare(left: &dyn Array, right: &dyn Array)
-> Result<DynComparato
#[cfg(test)]
pub mod tests {
use super::*;
- use crate::array::{Float64Array, Int32Array};
+ use crate::array::{FixedSizeBinaryArray, Float64Array, Int32Array};
use crate::error::Result;
use std::cmp::Ordering;
+ #[test]
Review Comment:
Even better would be some tests with more than one value in the list, and
some tests of more than just `Ordering::Less` :sweat_smile:
##########
arrow/src/array/ord.rs:
##########
@@ -307,10 +315,34 @@ pub fn build_compare(left: &dyn Array, right: &dyn Array)
-> Result<DynComparato
#[cfg(test)]
pub mod tests {
use super::*;
- use crate::array::{Float64Array, Int32Array};
+ use crate::array::{FixedSizeBinaryArray, Float64Array, Int32Array};
use crate::error::Result;
use std::cmp::Ordering;
+ #[test]
Review Comment:
Even better would be some tests with more than one value in the list, and
some tests of more than just `Ordering::Less`, but don't feel strongly
:sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
