andygrove commented on code in PR #414:
URL: https://github.com/apache/arrow-ballista/pull/414#discussion_r1001298528
##########
ballista/scheduler/src/state/mod.rs:
##########
@@ -256,11 +260,46 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerState<T,
plan: &LogicalPlan,
) -> Result<()> {
let start = Instant::now();
+
+ // optimizing the plan here is redundant because the physical planner
will do this again
+ // but it is helpful to see what the optimized plan will be
Review Comment:
That's a good point. Maybe we just need to check the first path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
