tustvold commented on code in PR #2908:
URL: https://github.com/apache/arrow-rs/pull/2908#discussion_r1001387547
##########
arrow/src/compute/kernels/sort.rs:
##########
@@ -146,7 +146,9 @@ pub fn sort_to_indices(
let (v, n) = partition_validity(values);
Ok(match values.data_type() {
- DataType::Decimal128(_, _) => sort_decimal(values, v, n, cmp,
&options, limit),
+ DataType::Decimal128(_, _) => {
+ sort_primitive::<Decimal128Type, _>(values, v, n, cmp, &options,
limit)
Review Comment:
I think this needs to call with_precision_and_scale afterwards to avoid
losing this metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
