raulcd commented on code in PR #14469:
URL: https://github.com/apache/arrow/pull/14469#discussion_r1001586641
##########
dev/release/05-binary-upload.sh:
##########
@@ -114,23 +116,37 @@ if [ ${UPLOAD_UBUNTU} -gt 0 ]; then
fi
rake_tasks+=(summary:rc)
-tmp_dir=binary/tmp
-mkdir -p "${tmp_dir}"
-source_artifacts_dir="${tmp_dir}/artifacts"
-rm -rf "${source_artifacts_dir}"
-cp -a "${artifact_dir}" "${source_artifacts_dir}"
-
-docker_run \
- ./runner.sh \
- rake \
- "${rake_tasks[@]}" \
- APT_TARGETS=$(IFS=,; echo "${apt_targets[*]}") \
- ARTIFACTORY_API_KEY="${ARTIFACTORY_API_KEY}" \
- ARTIFACTS_DIR="${tmp_dir}/artifacts" \
- DEB_PACKAGE_NAME=${DEB_PACKAGE_NAME:-} \
- DRY_RUN=${DRY_RUN:-no} \
- GPG_KEY_ID="${GPG_KEY_ID}" \
- RC=${rc} \
- STAGING=${STAGING:-no} \
- VERSION=${version} \
- YUM_TARGETS=$(IFS=,; echo "${yum_targets[*]}")
+if [ ${#rake_tasks[@]} -gt 1 ]; then
Review Comment:
whoah, I just learned what this does `${#rake_tasks[@]}` :exploding_head:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
