benibus commented on code in PR #14450:
URL: https://github.com/apache/arrow/pull/14450#discussion_r1002555549
##########
cpp/src/arrow/type.cc:
##########
@@ -2462,6 +2462,10 @@ void InitStaticData() {
// Temporal types
g_temporal_types = {date32(),
date64(),
+ duration(TimeUnit::SECOND),
+ duration(TimeUnit::MILLI),
+ duration(TimeUnit::MICRO),
+ duration(TimeUnit::NANO),
Review Comment:
That may be the case. I opted to include them in the temporal group based on
their common usage of `TimeUnit`s and an integral `c_type`, but perhaps that's
an arbitrary categorization. On first glance, it seemed like an unintentional
omission.
Now that you mention it, the `kernels/scalar_cast_string.cc` implementation
must exclude interval types as well, since it only sources from `TemporalTypes`
in `AddTemporalToStringCasts` - so maybe its a better idea to solve the issue
there (after adding a separate category for duration types, like you suggested).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
