waitingkuo commented on code in PR #2909:
URL: https://github.com/apache/arrow-rs/pull/2909#discussion_r1003055425
##########
arrow-array/src/timezone.rs:
##########
@@ -0,0 +1,306 @@
+use arrow_schema::ArrowError;
+use chrono::format::{parse, Parsed, StrftimeItems};
+use chrono::FixedOffset;
+pub use private::{Tz, TzOffset};
+
+/// Parses a fixed offset of the form "+09:00"
+fn parse_fixed_offset(tz: &str) -> Result<FixedOffset, ArrowError> {
+ if tz.len() != 6 {
Review Comment:
https://github.com/apache/arrow-rs/pull/2909/files#diff-fe32c157c2dda897288cc93386e455e6a0bdc0c63ce14776053a894ca61665ebR100-R104
`from_timestamp` is replaced by `from_timestamp_opt` in #2849
I tried to rebase this branch with master and it worked well 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
