kou commented on code in PR #14472:
URL: https://github.com/apache/arrow/pull/14472#discussion_r1003675091
##########
java/c/src/main/java/org/apache/arrow/c/jni/JniLoader.java:
##########
@@ -33,7 +33,7 @@
* The JniLoader for C Data Interface API's native implementation.
*/
public class JniLoader {
- private static final JniLoader INSTANCE = new
JniLoader(Collections.singletonList("arrow_cdata_jni"));
+ private static final JniLoader INSTANCE = new
JniLoader(Collections.singletonList(System.getProperty("os.arch") +
".arrow_cdata_jni"));
Review Comment:
Sorry. I'm not sure. I just found that a Maven plugin uses `toLowerCase()`:
https://maven.apache.org/enforcer/enforcer-rules/requireOS.html
BTW, we may need to the same normalization logic as os-maven-plugin to use
the same values as `os.detected.arch`:
https://github.com/trustin/os-maven-plugin/blob/master/src/main/java/kr/motd/maven/os/Detector.java#L192-L262
Or we may want to use `${os.arch}`/`SystemgetProperty("os.arch")` instead
of `${os.detected.arch}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
